AquaMail Forum
English - Android => Development builds => Topic started by: Kostya Vasilyev on October 16, 2013, 01:44:13 am
-
http://www.aqua-mail.com/download/AquaMail-market-1.2.5.12.apk
This has been requested a lot:
+ Phone numbers in messages are now clickable links.
The app now has to parse HTML content inside messages. I'm sure some particularly nasty (malformed) messages, broken in ways that I've not seen yet, can cause my HTML lexer to malfunction.
In this case, please send the original source of such messages to kmansoft / gmail / dot com as attachments. Original message sources are easy to obtain in web mail (GMail and others) or most desktop mail apps.
As an alternative, please enable debug logging with "session data" enabled, then open a message and use Menu / Diag: reload (last item) to record its contents in the app's own debug log. Then send the debug log to the address above.
Positive side effects:
1 - Two panel animations when opening a message are now smother. To make them as smooth as I'd like, still need to get rid of Android's built-in TextView objects inside each message item layout. However, I see an improvement in this version on my 2012 Nexus 7 and 2011 Acer A100.
2 - Replying to a message that has HTML content and no plain text content, causing the latter to be extracted from the former... no longer causes a long pause. HtmlCleaner is a fantastic library, just not written with mobile devices in mind... glad I don't have to use it anymore.
And now for my Russian users:
+ Телефонные номера в сообщениях теперь работают по нажатию как ссылки.
Для этого программе приходится делать полный лексический разбор HTML сообщений.
Очень вероятно, что найдутся кривые сообщения, на которых этот код будет неверно работать.
В таком случае - прошу слать исходники проблемных сообщений на kmansoft / собака / gmail / точка com. Исходники можно получить в веб-почте (gmail, yandex, mail.ru, rambler) или в почтовой программе. Также можно включить собственный отладочный лог, с записью данных сессии, и открыв письмо, сделать Меню / перезагрузить (последний пункт).
Также, как побочные эффекты:
1) стали более плавными анимации двух-панельного режима при открытии сообщения (хотя для полного счастья, еще нужно выкинуть Андроидные TextView из списка сообщений) и
2) при ответе на письмо, в котором только HTML и нет простого текста, то есть его нужно извлекать из HTML, пропали значительные задержки на эту процедуру (HtmlCleaner - наверное, прекрасная библиотека, но производительность - явно не для мобильных устройств...)
-
Everything working well but get force close and unable to open if in a no service area. Only able to use if switch to airplane mode in no service areas
-
Hello,
Thanks, yes, I'm gradually becoming aware of this issue... The networking code did change a bit (for EWS)...
So far I'm unable to reproduce the issue on my devices. Do you think it would be possible for you to capture the issue in a debug log and email it to me, as described below?
http://www.aqua-mail.com/?page_id=232
This would really help me fix the issue. Thanks in advance!
-
Never mind - I just got a debug log from someone else and was able to fix the issue.
Will post a new build on the forum tonight.
-
http://www.aqua-mail.com/download/AquaMail-market-1.2.5.12.apk
This has been requested a lot:
+ Phone numbers in messages are now clickable links.
Nice feature, but is there any chance to get an option
to disable this behavior?
Not only phone numbers are clickable, lots of other
numbers are too.
Stefran
-
Didn't upgrade yet but seems annoying as you say if every number out there gets a link. :P
-
Didn't upgrade yet but seems annoying as you say if every number out there gets a link. :P
Not ALL numbers, but a lot.
I get a lot of Mails with numeric data.
e.g.
10-000802b4ddea (here 10-000802 is recognized as telephone number)
10-000802b57507 (here 10-000802 and 57507 are recognized as telephone numbers)
But a date, e.g. 2013 is not recognized as telephone number.
Stefan
-
It's difficult to avoid false positives when detecting phone numbers.
People write things like:
Call me at 123-456, and do it soon (comma).
My number is 123-456. (period)
They might forget to types spaces where needed.
Etc, etc etc.
Is there a real issue here, or is it just "the app doesn't read the sender's mind"?
-
Well, my tablet has no phone. It would be nice to turn off the feature in settings, or to recognise somehow there is no phone. I appreciate that I just might want to add it to the people app or a calendar app, but up till now I have not done this more than a handful of times....
-
Ah, of course! Thanks, that's something I didn't think about!
-
Well, that didn't work out...
A device without real telephone hardware may have SIP VOIP, and my Nexus 7 reports it has it, even though I don't have any SIP software.
Let's see.
I'll try to crank down on false positives, my idea is to check the preceding / succeeding characters and only allow things like spaces and punctuation. This should handle the "10-000802b4ddea" etc.
If that's still not good enough, I'll consider a setting as a way to turn the whole thing off.
-
Well, that didn't work out...
A device without real telephone hardware may have SIP VOIP, and my Nexus 7 reports it has it, even though I don't have any SIP software.
Let's see.
I'll try to crank down on false positives, my idea is to check the preceding / succeeding characters and only allow things like spaces and punctuation. This should handle the "10-000802b4ddea" etc.
If that's still not good enough, I'll consider a setting as a way to turn the whole thing off.
Good point about the VoIP. Never thought of that.
-
@beaky, @jcasares - please try this new build:
http://www.aqua-mail.com/forum/index.php?topic=1705.0
-
Attached some examples with the new version.
Failed with an IP, a MAC address and a date in one way of formatting it.
Didn't fail with IDs used here that is a good thing.
-
Hello,
IP addresses, IMEI's, dates separated by dots look just like phone numbers.
Maybe I can add another check for the IP address case, where digits continue after a dot.
Mac addresses separated by dashes also look like phone numbers. It's more common to write them with ":"-s.
So far I've had very positive feedback to this feature, even before last night's false positive improvement.
On the other hand, it seems that you, @jcasares and @beaky, do not like it.
It's never going to be perfect.. digits are digits, they're used for far more than phone numbers.
Should I provide a way to turn this off entirely?
-
Fixed IP address false positives:
http://www.aqua-mail.com/forum/index.php?topic=1705.0
Let's move further discussion under 1.2.5.13, too.
-
The problem is if it gets in the way. When you get sent a MAC or an IP and you need to copy them, having a link is troublesome as it gets pressed while you're selecting the text. I get this in another apps already.
Why would phones have dots? That's not normal in contrast with MAC address having dashes (http://en.wikipedia.org/wiki/MAC_address). I would ditch those. That's an Internet times' distortion I would like to get rid (http://en.wikipedia.org/wiki/National_conventions_for_writing_telephone_numbers).
We are the ones voicing it now. Wait until you publish it to the store and then you will get a lot of complains, and for people that don't want the phones as link either.
The problem with options is that we already have too much. We need to think a way to provide the important ones easily and the rest hiding them in a tweakers place.
-
Well, I've never seen a MAC address written with "."-s.
People will write phone numbers with dots just because they feel like it.
A setting (on by default) is the only solution I see, short of jumping off a tall building :)
-
I never said dots for a MAC (but Cisco uses it, I don't know why). Just dashes and colons are the common uses. Here a lot of people use spaces to separate parts of phones. Should we use then spaces? I believe the best compromise is not to use dots to detect phone numbers and keep detection automatic.
But of course an option to disable that would be wise for people that don't agree with either point of view.
-
I have never seen dots in phonenumbers either. So I would say
- leave out the dots in detection as default
- add an option for turning the detection off
- add an expert setting for expressions (a text field in which you can add e.g. ".," so that . and , would be included in the detection algo)
- do NOT under any circumstances jump from a tall building. This could result in serious health problems. :-)
Gesendet von meinem GT-N7100 mit Tapatalk 2
-
Well I have seen dots (in actual email messages). The phone number pattern in the Android framework allows dots and spaces both.
Spaces are already included in my pattern.
I already wrote there will be a setting to turn the whole thing off.
PS - I wonder how many people will be unhappy when I implement swipe gestures.
PPS - Tapatalk HD's text input area, when replying, is too small, just three lines. I am a paid customer, please fix immediately by adding a setting for the number of lines, with "automatic" as an option. Scrolling is jerky, too, how could you release software like that?
Отправлено из моего GT-N7100 с помощью Tapatalk